Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super-fy the zed command doc #5460

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Super-fy the zed command doc #5460

merged 2 commits into from
Nov 11, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Nov 10, 2024

If reviewers would like to just read the content in rendered form, I've published it to a personal staging site. The primary updated article is at https://spiffy-gnome-8f2834.netlify.app/docs/next/commands/super-db.

@philrz philrz self-assigned this Nov 10, 2024
Comment on lines +34 to +37
A SuperDB data lake is a cloud-native arrangement of data, optimized for search,
analytics, ETL, data discovery, and data preparation
at scale based on data represented in accordance
with the [Zed data model](../formats/zed.md).
with the [super data model](../formats/zed.md).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in #5457, I know this top-level "what is it" summary needs to change, but I have difficulty coming up with the right wording. Happy to take suggestions or have someone else take a crack in a follow-up PR.

Comment on lines +187 to +188
- `%LOCALAPPDATA%\super` on Windows
- `$HOME/.local/share/super` on Linux and macOS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are aspirational paths in anticipation of a future change in the code.

lake can be easily queried.

If a writer commits data after and while a reader is scanning, then the reader
If a writer commits data after or while a reader is scanning, then the reader
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to call extra attention to this change. The and didn't read right. But if I'm missing something, please correct me.

Comment on lines +662 to +664
The `query` command runs a [SuperSQL](../language/README.md) query with data from a lake as input.
A query typically begins with a [`from` operator](../language/operators/from.md)
indicating the pool and branch to use as input.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amputated some text here because of the changes in #5418.

@philrz philrz marked this pull request as ready for review November 10, 2024 21:16
@philrz philrz requested a review from a team November 10, 2024 21:16
@philrz philrz merged commit 9cf4f08 into main Nov 11, 2024
4 checks passed
@philrz philrz deleted the docs-commands-zed-superfy branch November 11, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants